nodejs/node

Cpplint produces false positives for FastApiOptions

クローズ

#45,761 opened on 2022/12/06

 (10 件のコメント) (0 件のリアクション) (0 人の担当者)JavaScript (35,535 件のフォーク)batch import
c++good first issuepythonstale

Repository metrics

Stars
 (117,218 個のスター)
PR merge metrics
 (PR metrics pending)

説明

Following line is a perfectly fine declaration for v8 fast API.

using CFunctionCallbackWithInput =
    void (*)(v8::Local<v8::Value> receiver,
             const v8::FastOneByteString& source,
             const v8::FastApiTypedArray<uint8_t>& destination,
             const v8::FastApiTypedArray<uint32_t>& result,
             v8::FastApiCallbackOptions& options);

But it produces the following error

Running C++ linter...
src/node_encoding.cc:101:  Is this a non-const reference? If so, make const or use a pointer: FastApiCallbackOptions& options  [runtime/references] [2]
Done processing src/node_encoding.cc
src/node_external_reference.h:20:  Is this a non-const reference? If so, make const or use a pointer: v8::FastApiCallbackOptions& options  [runtime/references] [2]
Done processing src/node_external_reference.h
Total errors found: 2
make: *** [tools/.cpplintstamp] Error 1

コントリビューターガイド