nodejs/node

Merge streams handling code for http2 streams & net.Socket

Open

#19,060 opened on 2018年2月28日

GitHub で見る
 (28 comments) (0 reactions) (0 assignees)JavaScript (35,535 forks)batch import
help wantedhttp2net

Repository metrics

Stars
 (117,218 stars)
PR merge metrics
 (平均マージ 18d 17h) (30d で 219 merged PRs)

説明

Hey :)

It would be great if we could unify all the code from net and http2 that is only concerned with pushing data to/from the underlying stream, ideally into a common base class of net.Socket and Http2Stream, so that we could also maybe port some of the other native streams (zlib, fs) to using StreamBase on the native side & generally just share a lot of code.

This is probably not an easy task, and probably not doable in one pass, because the http2 and net implementations are always just slightly different, but if anybody wants to try to start working on this, feel free to reach out by commenting here.

コントリビューターガイド