Crash on bonding · noble/bleno#345

(1 comment) (3 reactions) (0 assignees)JavaScript (2,083 stars) (465 forks)batch import

help wanted

説明

Executed option "Bond" on Bleno device in nRF Connect. Following stacktrace appears

PROJECT/node_modules/bleno/lib/hci-socket/crypto.js:60
  var output = new Buffer(input.length);
                               ^

TypeError: Cannot read property 'length' of undefined
    at swap (PROJECT/node_modules/bleno/lib/hci-socket/crypto.js:60:32)
    at e (PROJECT/node_modules/bleno/lib/hci-socket/crypto.js:37:9)
    at Object.c1 (PROJECT/node_modules/bleno/lib/hci-socket/crypto.js:22:9)
    at Smp.handlePairingRandom (PROJECT/node_modules/bleno/lib/hci-socket/smp.js:130:12)
    at Smp.onAclStreamData (PROJECT/node_modules/bleno/lib/hci-socket/smp.js:58:10)
    at emitTwo (events.js:92:20)
    at emit (events.js:172:7)
    at AclStream.push (PROJECT/node_modules/bleno/lib/hci-socket/acl-stream.js:26:10)
    at BlenoBindings.onAclDataPkt (PROJECT/node_modules/bleno/lib/hci-socket/bindings.js:201:21)
    at emitThree (events.js:97:13)

hcidump.log

bleno 0.4.2 (from git) Distribution: Debian (Kali Linux) bluez 5.47

Linux POLO-1158 4.13.0-kali1-amd64 #1 SMP Debian 4.13.4-2kali1 (2017-10-16) x86_64 GNU/Linux

コントリビューターガイド

技術スタック: javascriptnodejs
領域: backendapi
Issue 種別: bug
難度: 2
推定時間: under 1 hour
活動状況: stale
明確さ: clear
前提条件: なし
初心者向け度: 60
調査方針: The crash occurs in `bleno/lib/hci socket/crypto.js` at the `swap` function where `input` is undefined. This happens during BLE pairing when `c1` is called with undefined. Review the call chain: `Smp.handlePairingRandom` calls `c1` with possibly undefined values. The fix should add a null check on `input` in `swap` or ensure the caller provides valid data. Check the hcidump.log for context, but a simple guard clause should resolve.