nightwatchjs/nightwatch

`frame()` command doesn't support page object element

Open

#3,655 opened on 2023年3月25日

GitHub で見る
 (7 comments) (0 reactions) (1 assignee)JavaScript (11,707 stars) (1,289 forks)batch import
buggood first issuehacktoberfest

説明

Description of the bug/issue

When I use frame() command, I expect the page object element can be used as a selector, but actually, it won't work.

Steps to reproduce

Try using frame() with a page object element.

Sample test

myPage.api.frame('@myIframe')

Nightwatch.js Version

2.6.14

Additional Information

See Discord discussion https://discord.com/channels/618399631038218240/1088668054650626058

David Burns - AutomatedTester — Yesterday at 21:33 I think this might need a bug raised. That doesn't seem right andrei — Today at 01:42 when using page objects, elements passed to commands on the .api namespace aren't resolved automatically. but we can easily add the frame() command on the main page object namespace Currently .frame() is implemented as a "protocol" command, so we will need to move it to the element-commands and update the implementation as needed. It's a relatively straightforward task.

コントリビューターガイド

技術スタック
javascriptnodejs
領域
testing
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Nightwatch.js basicsPage object modelJavaScript
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
70
調査方針
Examine the existing implementation of `frame()` as a protocol command (likely in `nightwatch/lib/api/commands/` or similar). Look at how other element commands like `click` are implemented as element commands, including how they resolve page object elements. Then modify `frame()` to follow that pattern. Check the Discord discussion for additional context.