nextcloud/server

Migrations generated via occ fail psalm validation

オープン

#34,555 opened on 2022/10/12

 (3 件のコメント) (0 件のリアクション) (0 人の担当者)PHP (4,865 件のフォーク)batch import
1. to developfeature: install and updategood first issueneeds reviewtechnical debt

Repository metrics

Stars
 (34,953 個のスター)
PR merge metrics
 (平均マージ 20d) (30d で 627 merged PRs)

説明

Actually such migrations fail psalm:

Error: ….php:42:56: MoreSpecificImplementedParamType: Argument 2 of …::changeSchema has the more specific type 'Closure():OCP\DB\ISchemaWrapper', expecting 'Closure' as defined by OCP\Migration\SimpleMigrationStep::changeSchema (see https://psalm.dev/140)

So I guess we have to revert it or update the base class as well?

Originally posted by @nickvergessen in https://github.com/nextcloud/server/issues/34488#issuecomment-1275904697

コントリビューターガイド