nextcloud/server

Cleanup Server.php (aliases & services)

オープン

#12,225 opened on 2018/11/02

 (3 件のコメント) (0 件のリアクション) (0 人の担当者)PHP (4,865 件のフォーク)batch import
1. to developgood first issuetechnical debt

Repository metrics

Stars
 (34,953 個のスター)
PR merge metrics
 (PR metrics pending)

説明

As discussed with @MorrisJobke

We regsiter a lot of plain text aliases like https://github.com/nextcloud/server/blob/9319d557a4b1156d82d824cdb1b7d6f07ad3fbde/lib/private/Server.php#L182

They should all die. Services should be queries properly using their servicename.

Ideally we also remove as much simple wrappers as possible like: https://github.com/nextcloud/server/blob/9319d557a4b1156d82d824cdb1b7d6f07ad3fbde/lib/private/Server.php#L256-L258 The DI can handle that all perfectly by itself when it is actually needed.

コントリビューターガイド