nextcloud/android

Encryption passphrase regenerates when you switch apps

Open

#11,571 opened on 2023年4月28日

GitHub で見る
 (2 comments) (0 reactions) (0 assignees)Java (3,752 stars) (1,719 forks)batch import
E2Ebugfeature: encryption (client-side)good first issue

説明

⚠️ Before posting ⚠️

  • This is a bug, not a question or an enhancement.
  • I've searched for similar issues and didn't find a duplicate.
  • I've written a clear and descriptive title for this issue, not just "Bug" or "Crash".
  • I agree to follow Nextcloud's Code of Conduct.

Steps to reproduce

When setting up encryption, the app creates and shows you a new passphrase. If you decide to copy the passphrase and then paste it into a password manager, then come back to the app, it will then create a new passphrase, different from the one you pasted into your password manager, leading to the encryption passphrase being lost.

Expected behaviour

After the passphrase dialog appears, I would expect the passphrase to not change until I click cancel and then "set up encryption" again.

Actual behaviour

Any time you switch apps and come back the passphrase gets recreated.

Android version

10

Device brand and model

Oneplus 6

Stock or custom OS?

Stock

Nextcloud android app version

3.24.2

Nextcloud server version

26.0.1

Using a reverse proxy?

Yes

Android logs

Not using a beta version, but I don't think logs would be required for this issue.

Server error logs

N/A

Additional information

Screen recording: https://nextcloud.jordanle.es/s/PkcACNNecMifpkD

If the link doesn't work, then ping me and I'll fix it (I'm still fiddling with my Nextcloud instance so it might bork)

コントリビューターガイド

技術スタック
javaandroid
領域
mobilesecurity
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
fresh
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Android development basicsUnderstanding of Activity lifecycle
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
60
調査方針
Investigate the encryption setup dialog flow in the Nextcloud Android app. Look for where the passphrase is generated (likely in an Activity or Fragment handling encryption setup). Check why the passphrase regenerates when the app comes back to foreground (e.g., onResume()). Focus on the dialog creation and state preservation, possibly in files like `EncryptionActivity.java` or related fragments. Review lifecycle methods to ensure the passphrase is only generated once per dialog session.