musescore/MuseScore

Fretboard diagram properties: Accept T, t, P, and p as valid fingerings

Open

#23,755 opened on 2024年7月24日

GitHub で見る
 (3 comments) (0 reactions) (2 assignees)C++ (11,122 stars) (2,432 forks)batch import
P3UX/interactioncommunityengravinggood first issue

説明

Issue type

UX/Interaction bug (incorrect behaviour)

Description with steps to reproduce

Currently, only numeric characters 1-5 are valid entries for fingerings on fretboard diagrams. "T" and "t" should also be accepted, to indicate "thumb" (example below) as well as "P" and "p" for pulgar as pointed out here.

image

Supporting files, videos and screenshots

I should be able to enter "T" in this box.

What is the latest version of MuseScore Studio where this issue is present?

4.4 Nightly

Regression

No.

Operating system

macOS 14.5

Additional context

No response

Checklist

  • This report follows the guidelines for reporting bugs and issues
  • I have verified that this issue has not been logged before, by searching the issue tracker for similar issues
  • I have attached all requested files and information to this report
  • I have attempted to identify the root problem as concisely as possible, and have used minimal reproducible examples where possible

コントリビューターガイド

技術スタック
cpp
領域
desktop
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
blocked
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
C++
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
30
調査方針
Investigate the validation logic for fretboard diagram fingerings in the MuseScore source code. The code currently only accepts numeric 1-5; locate the validation function (likely in a file related to fretboard diagrams, e.g., 'fretboard.cpp'). Modify it to accept 'T', 't', 'P', and 'p' as valid inputs. Ensure consistent handling of case and update any related UI hints if present.