mozilla/testpilot

Refine .eslintrc rules for node vs browser JS

オープン

#3,228 opened on 2018/01/10

 (6 件のコメント) (0 件のリアクション) (0 人の担当者)FreeMarker (108 件のフォーク)auto 404
dev papercutgood first issueskill:js

Repository metrics

Stars
 (250 個のスター)
PR merge metrics
 (PR metrics pending)

説明

As @pdehaan mentions:

What about just specifying the ESLint environment in the gulpfile.babel.js and webpack.config.js, a la /* eslint-env node, browser, whatever */. Or if we want to set the node env for a directory, we could just use a nested .eslintrc file (for tests or gulp tasks or whatnot).

We've got a pretty broad set of globals and envs covering all of our JS for linting, right now. But, some JS is for the build chain in node and some are for running in the browser. Might be nice to use per-directory & file glob eslint overrides to further focus what's allowed for various source files.

コントリビューターガイド