[Send 2][Enhancement] Clicking inside the “Privacy” overlay should dismiss it · mozilla/send#1304

2019-04-22T11:24:12.000Z

**[Notes]:** - There should be consistency regarding the dismissal of the overlay considering that the upload complete and Sign in/up overlays are dismissed when clicking inside them. **[Affected versions]:** - Firefox 66.0.3 and up - Chrome Version 73.0 **[Affected Platforms]:** - All Mac - All Windows - All Linux **[Steps to reproduce]:** 1. Open the browser and navigate to the https://send.firefox.com/ website. 2. Click the “Privacy” button. 3. Click inside the overlay but not on any actionable buttons. **[Expected result]:** - The overlay is dismissed. **[Actual result]:** - The overlay is still displayed. **[Additional Notes]:** - This issue is also reproducible on the https://send2.dev.lcip.org website. - Attached a screen recording with the issue: ![rec of issue - overlay dismissal](https://user-images.githubusercontent.com/37875464/56498368-09341f80-650a-11e9-96d2-6f26b397b128.gif)

(6 comments) (0 reactions) (0 assignees)JavaScript (13,154 stars) (1,239 forks)batch import

[QA]:Enhancementgood first issueskill:js

説明

[Notes]:

There should be consistency regarding the dismissal of the overlay considering that the upload complete and Sign in/up overlays are dismissed when clicking inside them.

[Affected versions]:

Firefox 66.0.3 and up
Chrome Version 73.0

[Affected Platforms]:

All Mac
All Windows
All Linux

[Steps to reproduce]:

Open the browser and navigate to the https://send.firefox.com/ website.
Click the “Privacy” button.
Click inside the overlay but not on any actionable buttons.

[Expected result]:

The overlay is dismissed.

[Actual result]:

The overlay is still displayed.

[Additional Notes]:

This issue is also reproducible on the https://send2.dev.lcip.org website.
Attached a screen recording with the issue:

rec of issue - overlay dismissal

コントリビューターガイド

技術スタック: javascripthtmlcss
領域: frontend
Issue 種別: bug
難度: 2
推定時間: under 1 hour
活動状況: stale
明確さ: clear
前提条件: Basic JavaScriptFamiliarity with event handling in the browser
初心者向け度: 80
調査方針: The issue requires adding a click handler to dismiss the Privacy overlay when clicking inside it (but not on actionable buttons). Look at how other overlays (upload complete, sign in/up) handle dismissal for consistency. The codebase is likely JavaScript with HTML/CSS. Check the overlay component and its event listeners. Review the 6 comments on the issue for any additional context or attempted solutions.