mozilla/DeepSpeech
Change Alphabet::EncodeSingle and Alphabet::DecodeSingle to use an outparam and return an error code instead of calling `abort`
オープン
#3,175 opened on 2020/07/22
buggood first bughelp wanted
Repository metrics
- Stars
- (26,755 個のスター)
- PR merge metrics
- (PR metrics pending)
説明
I run into the error "Invalid label 0". I assume it is from the function Alphabet::DecodeSingle() in the file native_client/alphabet.cc.
I don't know why I am running into this error and it is not important for now. What is important is the fact that the code calls abort() just after printing this error.
I don't know your guidelines. But I can tell that aborting the whole process, including the python interpreter which might be interactive, is a terrible way of handling errors, especially in such a trivial function, and I call it a bug.