mozilla-mobile/firefox-ios

Adjust Downloads toast checkmark to be on the left side of the filename label

Open

#24,851 opened on 2025年2月20日

GitHub で見る
 (4 comments) (0 reactions) (0 assignees)Swift (3,203 forks)batch import
Contributor OKGood first issue

Repository metrics

Stars
 (12,950 stars)
PR merge metrics
 (平均マージ 3d 2h) (30d で 221 merged PRs)

説明

:page_facing_up: Description

Improve the DownloadToast on both orientations, correcting the checkmark icon that is currently displayed on top of the filename. The label should be on the left side of the filename label.

The final result should be the following:

| V -- filename | | ---- Button |

The checkmark icon has to be aligned with the filename baseline and the button with the filename leading, make sure to apply also padding between filename and button.

Please attach the screenshot for both orientation and also with dynamic font size, to check behavior with accessibility.

The toast in landscape hovers the safe area, this should be refactored to be within the safe area.

Make sure if needed to check orientation in the implementation to check against the size class and not the device type. (horizontalSizeClass)

Here is a link to the PR with image contexts https://github.com/mozilla-mobile/firefox-ios/pull/24773#issuecomment-2659428423

:information_source: Reference Person

FilippoZazzeroni

┆Issue is synchronized with this Jira Task

コントリビューターガイド