moleculerjs/moleculer

Incorrect work of metrics in cluster mode

Open

#809 opened on 2020年9月7日

GitHub で見る
 (6 comments) (0 reactions) (1 assignee)JavaScript (5,919 stars) (588 forks)batch import
Module: Metricshelp wanted

説明

Prerequisites

Please answer the following questions for yourself before submitting an issue.

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed
  • I'm reporting the issue to the correct repository

Current Behavior

Metrics are returned in turn from each worker in the cluster and include data about one current worker.

Expected Behavior

It is necessary to transfer the registration of metrics to the cluster master and the workers inform the master about their metrics via IPC or AggregatorRegistry

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. enable prometheus metrics
  2. moleculer-runner -i 2
  3. check metrics

Context

Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

  • Moleculer version: v0.14.10
  • NodeJS version: LTS
  • Operating System: linux

コントリビューターガイド

技術スタック
nodejs
領域
backendobservability
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Node.jsMoleculer frameworkprom client libraryNode.js cluster module
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
45
調査方針
Investigate the current metrics implementation in the Moleculer framework, particularly how metrics are registered in cluster workers. The expected solution involves moving metric registration to the master process and using IPC or the prom client AggregatorRegistry to aggregate metrics from workers. Look at the existing prom client example at https://github.com/siimon/prom client/blob/master/example/cluster.js for reference. Also check the Moleculer source code for files related to metrics handling.