mllam/neural-lam

Add type hints to methods in interaction_net.py

オープン

#448 opened on 2026/03/20

 (0 件のコメント) (0 件のリアクション) (0 人の担当者)Python (276 件のフォーク)auto 404
good first issuemaintenance

Repository metrics

Stars
 (282 個のスター)
PR merge metrics
 (PR metrics pending)

説明

Summary

The methods in neural_lam/interaction_net.py currently lack type annotations. mypy is already configured in pre-commit but cannot fully validate this module without proper type hints.

Methods affected

  • InteractionNet.forward
  • InteractionNet.message
  • InteractionNet.aggregate
  • SplitMLPs.forward

Proposed Fix

Add torch.Tensor, Optional[torch.Tensor], Tuple and Union type hints to all method signatures and return types.

Why This Matters

  • mypy is already set up in .pre-commit-config.yaml
  • Type hints improve contributor experience and catch bugs early
  • Consistent with type hints already added in metrics.py (see #446)

コントリビューターガイド