miraclx/freyr-js

Songs downloaded as clean version when they aren't supposed to.

Open

#406 opened on 2022年12月30日

GitHub で見る
 (4 comments) (0 reactions) (0 assignees)JavaScript (2,279 stars) (154 forks)user submission
enhancementgood first issuehelp wanted

説明

Some songs downloaded off Apple Music seems to be downloaded as a clean version while other songs from the same album isn't, listening to the preview of the song in Apple Music indicates the song isn't clean however Freyr seems to download a clean version for whatever reason.

Some songs this has occurred on:

I am sure there is other songs that this is occurring on as well but these are from my personal experience.

To reproduce:

  • Download the entire album
  • Play the song
  • Song is the clean version Edit: This also happens when downloading the same song separately. Edit 2: This doesn't happen when downloading songs from Spotify, only from Apple Music, I don't know about Deezer still as I won't try it since I don't really use it.

This is on a fresh install of Freyr (version 0.9.0) on Arch Linux, as I said above other songs from the same album is downloaded without issues but these two I listed is downloaded as a clean version, I'll listen to other songs from different albums and artists and report back, I don't know if this issue occurs on different services (Spotify & Deezer) since I haven't tried them.

コントリビューターガイド

技術スタック
javascriptnodejs
領域
backend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
JavaScriptNode.js
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
40
調査方針
Investigate the Apple Music download logic in freyr js. Focus on how the tool determines if a song is clean or explicit. Review the metadata parsing for tracks like 'Change My Life' and 'Two' linked in the issue. Check the provider code for Apple Music (likely in src/providers/apple music/), and compare with the Spotify provider. Look for any differences in how the 'explicit' flag is handled. Test downloading those specific tracks to reproduce the bug. Consider if there is a fallback when explicit version is unavailable.