miraclx/freyr-js

Playlist download operation does not gracefully crash when certain songs present

Open

#169 opened on 2022年3月22日

GitHub で見る
 (9 comments) (0 reactions) (0 assignees)JavaScript (2,279 stars) (154 forks)user submission
action or closebuggood first issuequestion

説明

An Apple Music playlist (~99 songs) I was trying to download kept crashing with the following error:

[•] Collating...
  [•] Inquiring tracks...(failed: [Cannot read properties of undefined (reading '0')]) 
 [i] An error occurred while processing the query (Failed to collect playlist tracks)

After a lot of trial and error, I narrowed the problem down to a single track: "Watch - Nosaj Thing": https://music.apple.com/us/album/watch/1608121372?i=1608121589

Removing this single track from the playlist allowed the entire playlist to download successfully.

コントリビューターガイド

技術スタック
javascriptnodejsrest api
領域
backendtoolingapi
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
Basic JavaScriptError handlingApple Music API
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
40
調査方針
Investigate the track parsing logic in the Apple Music module. Look for where response data is accessed with index [0] without checking for undefined. The crash occurs on a specific track (Watch Nosaj Thing). Check if the track has missing or malformed data. Examine the code around the 'Inquiring tracks' step, likely in src/providers/apple music.js. Consider adding input validation and graceful error handling for such cases.