storePageIn() fails to find container in new doc if nested · miguel-perez/smoothState.js#193

(8 comments) (0 reactions) (0 assignees)CSS (4,433 stars) (515 forks)batch import

bughelp wanted

説明

Nesting the container even one level under the body tag prevents storePageIn() from find it.

<body>
    <div>
        <article id="js-smoothstate-content">
            <h1>TEST CONTENT</h1>
        </article>
    </div>
</body>

The filter() function won't find the container id (Chrome v43):

storePageIn: function (object, url, doc, id) {
    /../
    object[url] = { // Content is indexed by the url
        /../
        html: $newDoc.filter('#' + id), // Stores the contents of the page
    }; 
}

Consider using .find() instead?

コントリビューターガイド

技術スタック: javascript
領域: frontend
Issue 種別: bug
難度: 2
推定時間: under 1 hour
活動状況: stale
明確さ: clear
前提条件: basic JavaScriptjQuery
初心者向け度: 80
調査方針: The issue reports that storePageIn() uses .filter() to find the container element, which fails when the container is nested inside another element. The suggested fix is to use .find() instead. Check the source code in smoothState.js around the storePageIn function (likely lines 100-150) and verify that changing $newDoc.filter('#' + id) to $newDoc.find('#' + id) resolves the issue without breaking other functionality. Also ensure that the id is correctly scoped and that no other parts of the code rely on the .filter() behavior.