microsoft/perfview

Freeze processing in EventPipeEventSource if uncaught exception is thrown in callback.

Open

#1,290 opened on 2020年10月15日

GitHub で見る
 (0 comments) (0 reactions) (0 assignees)C# (3,819 stars) (687 forks)batch import
bughelp wanted

説明

Environment

  • Microsoft.Diagnostics.Tracing.TraceEvent: 2.0.61
  • Microsoft.Diagnostics.NETCore.Client: 0.2.141901
  • EventPipe sender app and receiver app's TFM: net5.0-rc2

Steps to reproduce

  1. run app which produce EventSource event periodically
  2. start EventPipe session by DiagnosticClient
  3. create EventPipeEventSource from event stream
  4. set callback to DynamicEventParser.All
    • Exception will be thrown in callback
  5. start processing

full test code is uploaded to gist

Expected result

callback is invoked periodicaly, or at least terminate event processing when EventPipeEventSource.StopProcessing is called.

Actual result

callback was never invoked again, and EventPipeEventSource.Process never returned, even if EventPipeEventSource.StopProcessing was called.

コントリビューターガイド

技術スタック
csharp
領域
observabilityperformance
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
needs investigation
前提条件
C#.NETEventPipe
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
20
調査方針
Investigate the EventPipeEventSource class in the Microsoft.Diagnostics.Tracing.TraceEvent library to understand how callbacks are invoked and how exceptions are handled. The issue shows that an uncaught exception in the callback causes the event loop to freeze. Look for try catch blocks around callback invocations and ensure exceptions are caught to avoid freezing. Also check the StopProcessing mechanism to ensure it can interrupt a frozen loop.