Missing operator delete/delete[] for some allocated objects · microsoft/Terminal#875

(7 comments) (0 reactions) (0 assignees)C++ (3,212 forks)batch import

Area-CodeHealthHelp WantedIssue-BugProduct-Conhost

Repository metrics

Stars: (35,764 stars)
PR merge metrics: (平均マージ 27d 19h) (30d で 24 merged PRs)

説明

Hi.

Looks like there are few places in the Terminal code where I can suspect a memory leaks due to missing operator delete or operator delete[]. These allocation sites can be grouped into following:

raw operator new without operator delete like this https://github.com/Microsoft/Terminal/blob/master/src/cascadia/TerminalConnection/ConptyConnection.cpp#L191
allocation by operator new some global object or class member (https://github.com/Microsoft/Terminal/blob/master/src/cascadia/TerminalControl/TermControl.cpp#L281)
allocation by operator new some memory in a function and return it by raw pointer, which can leak then.

Here is my gist with quite a simple grep foroperator new calls - https://gist.github.com/dreamer-dead/c43248466fc4d445378b4dfba80d8d25

Is this an intentional behaviour or a bug that should be fixed?

コントリビューターガイド

調査方針: gistにリストされた各割り当てサイト（例：ConptyConnection.cpp 191行、TermControl.cpp 281行）を調査し、不足している operator delete/delete[] 呼び出しを追加してください。リークを防ぐためにRAIIやスマートポインタの使用を検討してください。
技術スタック: cpp
領域: backend
Issue 種別: バグ
難度: 3
推定時間: 1-3時間
活動状況: アクティブ
明確さ: 明確
前提条件: C++Memory Management
初心者向け度: 65

Repository metrics

説明

コントリビューターガイド

新着 Easy issues をメールで受け取る。