(1 comment) (0 reactions) (0 assignees)C++ (3,212 forks)batch import

Area-CodeHealthHelp WantedIssue-TaskPriority-3Product-Conhost

Repository metrics

Stars: (35,764 stars)
PR merge metrics: (平均マージ 27d 19h) (30d で 24 merged PRs)

説明

Environment

Windows build number: [run `[Environment]::OSVersion` for powershell, or `ver` for cmd] 10.0.19041.388
Windows Terminal version (if applicable): 1.0.1811.0 + recent preview

In #4493 @miniksa pointed out that the state should be a member of SCREEN_INFORMATION rather than a static variable in WriteConsoleAImpl. Refer to https://github.com/microsoft/terminal/pull/4493#discussion_r389024806 In the current code base it's still in WriteConsoleAImpl though. https://github.com/microsoft/terminal/blob/d0ff5f6b5e7687c438e0a8b120280be307eda778/src/host/_stream.cpp#L1107 Since I closed the PR I just don't want this information to get lost.

コントリビューターガイド

調査方針: PRディスカッション#4493と現在のコードsrc/host/ stream.cppを参照してください。静的変数u8StateをWriteConsoleAImplからSCREEN INFORMATIONクラスに移動し、すべての参照を更新してください。
技術スタック: cpp
領域: backend
Issue 種別: リファクタリング
難度: 2
推定時間: 1-3時間
活動状況: アクティブ
明確さ: 明確
前提条件: C++
初心者向け度: 75