microsoft/Terminal
Investigate include order issue with `InputBuffer`, `readData`
オープン
#4,262 opened on 2020/01/16
Area-CodeHealthHelp WantedIssue-TaskPriority-3Product-Conhost
Repository metrics
- Stars
- (103,173 個のスター)
- PR merge metrics
- (平均マージ 27d 19h) (30d で 24 merged PRs)
説明
Found in #4213.
I had to fwddecl InputBuffer, because I think there's a include order problem with in InputBuffer.hpp and readData.hpp.
readData.hpp uses InputBuffer in a bunch of places, but doesn't include it first
InputBuffer.hpp includes readData.hpp before it defines InputBuffer
So if you try to
#include ".../host/inputBuffer.hpp"
You'll get a compilation error, because it'll include readData, which will assume InputBuffer is defined, which it isn't yet.