microsoft/Terminal
Refactor `_GetProposedFont` into a static function
オープン
#11,763 opened on 2021/11/15
Area-CodeHealthArea-PerformanceHelp WantedIssue-TaskPriority-2Product-Terminal
Repository metrics
- Stars
- (103,173 個のスター)
- PR merge metrics
- (平均マージ 27d 19h) (30d で 24 merged PRs)
説明
Ported from MSFT-21254947
With Dart/OpenConsole!3129098, I instantiate an entire DxEngine just to get the initial size of the control.
Turns out there's only two things that _GetProposedFont really needs from the instance - the dwriteFactory, and the _chainMode. If we make those params, then we could make GetProposedFont a public static function, and not need to instantiate an entire engine (including all the dx resources it needs) just to get the font size.
We should not be spinning up an entire DX Renderer to ask it how big a cell should be.