Remove @NullUnmarked workaround for NullAway bug on generic types · micrometer-metrics/micrometer#6404

2025-06-14T00:09:08.000Z

It seems ` ` does not work well in some situations, see https://github.com/uber/NullAway/issues/1075. Because of this bug in NullAway, we need to use `@NullUnmarked` and "invert" the contract unnecessarily, see [here](https://github.com/micrometer-metrics/micrometer/pull/6385/files#diff-ded137c872c542917642b07bf544b3c5d4319a17a2f10fe771bf158f54390c11R59) and [here](https://github.com/micrometer-metrics/micrometer/pull/6385/files#diff-ded137c872c542917642b07bf544b3c5d4319a17a2f10fe771bf158f54390c11R72-R73).

(4 comments) (0 reactions) (0 assignees)Java (4,220 stars) (935 forks)batch import

help wantednullabilitypolishtype: task

説明

It seems <T extends @Nullable Object> does not work well in some situations, see https://github.com/uber/NullAway/issues/1075.

Because of this bug in NullAway, we need to use @NullUnmarked and "invert" the contract unnecessarily, see here and here.

コントリビューターガイド

技術スタック: java
領域: tooling
Issue 種別: refactor
難度: 3
推定時間: 1-3 hours
活動状況: blocked
明確さ: clear
前提条件: JavaNullAwayGenerics
初心者向け度: 60
調査方針: Examine the referenced PR #6385 and the specific lines where @NullUnmarked is used (see diff links in issue). Monitor the NullAway issue #1075 for the upstream fix. Once the NullAway bug is resolved, remove the @NullUnmarked annotations and revert the inverted contract. Update any relevant tests to ensure correctness without the workaround.