micro-analytics/micro-analytics-cli

Connection leaks in adapter tests

Open

#75 opened on 2017年6月29日

GitHub で見る
 (0 comments) (1 reaction) (0 assignees)JavaScript (52 forks)batch import
adapter-testshelp wanted

Repository metrics

Stars
 (738 stars)
PR merge metrics
 (30d に merged PR はありません)

説明

The adapter tests does not close connection correctly resulting in tests for the redis adapter never quitting.

The problem is the at the moment is call init should not throw. Overwrites the connections with new one and then when the tests closes connection in afterEach the connection created in beforeEach is not closed.

I think it would be a good thing to require adapter.close() and handle the closing of database connections in the adapter utils.

コントリビューターガイド