mesonbuild/meson

State corruption with multiple tasks running on same directory

Open

#2,922 opened on 2018年1月14日

GitHub で見る
 (2 comments) (0 reactions) (0 assignees)Python (4,978 stars) (1,465 forks)batch import
buggood first issuehelp wanted

説明

I ran ninja -C build after changing some options. At the middle, or towards the end, I hit ^Z to check on something. After checking, I totally forgot that the job was already running, and started it again. Realizing I had done that, I killed the new job, and resumed the old one. I got:

$ nice ninja -j4 -C armv7-build 
ninja: Entering directory `armv7-build'
[0/1] Regenerating build files.
Error during basic setup:

Something went terribly wrong. Please file a bug.
FAILED: build.ninja 
/usr/bin/python3.6 /home/ilia/src/meson/meson.py --internal regenerate /home/ilia/src/mesa-meson /home/ilia/src/mesa-meson/armv7-build --backend ninja
ninja: error: rebuilding 'build.ninja': subcommand failed

Do I now have to wipe the whole build directory and all the things that were already built in it?

コントリビューターガイド

技術スタック
python
領域
build system
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
4
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
3-5 days
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Understanding of Meson build systemBasics of file locking and concurrency
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
20
調査方針
The issue describes state corruption when two meson builds run concurrently in the same directory. Investigate file locking mechanisms used by Meson and Ninja, particularly around the build.ninja file and other intermediate files. Look at how Meson handles concurrent access and if there is any atomicity in file operations. Consider suggesting a lock file or a warning when a build directory is already in use. Review the Meson source code in mesonbuild/meson for relevant files like mesonbuild/mesonmain.py, backends/ninjabackend.py, and any state files.