mesonbuild/meson

Add a mechanism to add prefix/suffixes to configuration files

Open

#1,492 opened on 2017年3月22日

GitHub で見る
 (3 comments) (0 reactions) (0 assignees)Python (4,978 stars) (1,465 forks)batch import
enhancementhelp wanted

説明

Right now, with configure_file() if the input: kwarg is not set, we just dump the entire configuration. This has the advantage of not having to maintain a duplicate list of defines (one in meson.build, another in config.h.in) and is less error-prone.

However, this leaves a gap: sometimes the config.h is mostly generated, but has a few static defines in it. We should implement a way to also add these to the generated config.h. There are two ways to implement this:

  1. Add prefix: and suffix: kwargs to configure_file()

  2. Add a new token type #meson_dump_configuration (or similar) that can be put in config.h.meson that will dump the configuration_data() object in that place

The latter has the advantage of being more flexible, and the former has the advantage of having all the defines in one place (in meson.build).

コントリビューターガイド

技術スタック
python
領域
build system
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
3-5 days
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Familiarity with Meson build systemPython experience
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
25
調査方針
The issue proposes two approaches: adding `prefix:` and `suffix:` kwargs to `configure file()`, or introducing a `#meson dump configuration` token in config files. To implement, study the existing `configure file()` implementation in `mesonbuild/interpreter.py` and the `configuration data()` object. No linked PRs exist, so work should start from scratch. The maintainers have not clarified preference, so the contributor should choose based on flexibility and codebase consistency.