Change key actions to be bitflags · meilisearch/MeiliSearch#4645

(11 comments) (0 reactions) (0 assignees)Rust (20,887 stars) (733 forks)batch import

good first issuemaintenance

説明

Currently, the Meilisearch action keys are single numbers and therefore cannot be combined. It's not possible to OR them NOT them. I needed to do a basic documents.add | documents.delete for the edit documents by using a function feature.

We must use bitflags to define those actions and be able to combine them. We could have 32 or 64 different combinable actions. We already use this library in heed and it works very well.

コントリビューターガイド

技術スタック: rust
領域: backendauthenticationauthorization
Issue 種別: feature
難度: 3
推定時間: 1-3 hours
活動状況: active
明確さ: clear
前提条件: Rust programmingbitflags crateMeilisearch codebase overview
初心者向け度: 65
調査方針: Start by reviewing the existing key actions implementation in meilisearch types/src/keys.rs. Understand the current 'single numbers' approach and how actions are defined. Read the bitflags crate documentation to learn how to define combinable flags. Then, refactor the Action enum to use the bitflags macro, ensuring all existing action values are preserved. Update any code that compares or uses these action values to work with bitwise operations. Check for tests that need updates. Discuss any breaking changes in the issue comments.