Destroy Menubar · max-mapper/menubar#281

2020-04-27T16:00:39.000Z

[//]: # "Hey there and thank you for using Menubar's issue tracker!" [//]: # "Please fill in these information to describe your issue." ### Description There is no API to destroy a menubar instance. I'm implementing a feature in my application which will allow the end-users to run their Electron app in a tray or a window, but there is no mechanism to tear-down a menubar. ### Steps to Reproduce the Problem 1. Create a menubar 2. Destroy Window Reference 3. `Error: Object has been destroyed: at Menubar. (my-app/node_modules/menubar/lib/Menubar.js:311:72)` ### Expected Behaviour I'd like for the menubar instance to have a teardown function ### Actual Behaviour There is no API to support this ### Specifications - Menubar version: 6.0.8 - Platform: Mac - Electron version: 7.1.9 ### Other information

(1 comment) (2 reactions) (0 assignees)TypeScript (365 forks)github user discovery

good first issue

Repository metrics

Stars: (6,778 stars)
PR merge metrics: (PR metrics pending)

説明

Description

There is no API to destroy a menubar instance. I'm implementing a feature in my application which will allow the end-users to run their Electron app in a tray or a window, but there is no mechanism to tear-down a menubar.

Steps to Reproduce the Problem

Create a menubar
Destroy Window Reference
Error: Object has been destroyed: at Menubar.<anonymous> (my-app/node_modules/menubar/lib/Menubar.js:311:72)

Expected Behaviour

I'd like for the menubar instance to have a teardown function

Actual Behaviour

There is no API to support this

Specifications

Menubar version: 6.0.8
Platform: Mac
Electron version: 7.1.9

Other information

コントリビューターガイド

調査方針: Menubarクラスのライフサイクルを理解し、BrowserWindowとTrayを適切に破棄し、イベントリスナーを削除し、内部状態をリセットするdestroyメソッドを実装します。
技術スタック: typescriptnodejs
領域: desktop
Issue 種別: 機能
難度: 3
推定時間: 半日
活動状況: アクティブ
明確さ: 明確
前提条件: ElectronTypeScriptGit
初心者向け度: 60