matthewmueller/x-ray

Uncaught ECONNRESET exception

Open

#171 opened on 2016年4月9日

GitHub で見る
 (1 comment) (0 reactions) (0 assignees)JavaScript (5,804 stars) (415 forks)batch import
bughelp wanted

説明

Subject of the issue

I found that the following apparently uncaught exception occurred and crashed our Node process instead of being caught by x-ray and forwarded as an err:

events.js:154
      throw er; // Unhandled 'error' event
      ^

Error: read ECONNRESET
    at exports._errnoException (util.js:890:11)
    at TCP.onread (net.js:552:26)

Your environment

node v5.9.1 npm v3.7.3

Steps to reproduce

Scrape from a source which resets the connection remotely.

Expected behaviour

Expected exception to be caught by x-ray and passed to callback as err.

Actual behaviour

Uncaught exception crashes process.

(PS many thanks for a great lib)

コントリビューターガイド

技術スタック
javascriptnodejs
領域
backend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Node.js event handlingKnowledge of x ray library internals
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
30
調査方針
Investigate the x ray library's HTTP request handling to find where ECONNRESET errors are not caught. Look in the main driver file (likely index.js or driver.js) for where requests are made. Ensure that the error event on the response stream is properly handled and forwarded to the callback. The issue suggests that the error is emitted on the socket and not caught by x ray's promise or callback structure.
Uncaught ECONNRESET exception · matthewmueller/x-ray#171 | Good First Issue