mattermost/mattermost

Private playbooks with triggers show incorrectly in the channel when you do not have permissions

Open

#26,923 opened on 2024年4月29日

GitHub で見る
 (1 comment) (0 reactions) (1 assignee)TypeScript (32,880 stars) (7,823 forks)batch import
Help Wanted

説明

Summary

When you use the triggered playbook feature for a private playbook in a channel, it shows the playbook then deletes it creating a weird experience. See video.

Steps to repro

  1. Create a private playbook for a user
  2. Use channel actions to make that private playbook trigger when typing a keyword
  3. Switch to another user who’s not a member of that playbook
  4. use the trigger word in the channel
  5. Get prompted for the private playbook
  6. click run
  7. now the private playbook doesn’t show and the post was deleted

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-57844

コントリビューターガイド

技術スタック
typescriptreact
領域
frontendauthorization
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
blocked
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Familiarity with Mattermost frontendUnderstanding of playbooks permissionsExperience with React
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
30
調査方針
Investigate the playbooks plugin frontend code, specifically the channel actions trigger and permission checks. Look at the flow where a private playbook is shown and then hidden when the user lacks permissions. The issue is assigned, so coordinate with the assignee before starting work.