mattermost/mattermost

Prevent System bot from becoming disabled

クローズ

#26,575 opened on 2024/03/25

 (2 件のコメント) (0 件のリアクション) (1 人の担当者)TypeScript (7,823 件のフォーク)batch import
Area/Bot AccountsDifficulty/2:MediumHelp WantedTech/GoTech/ReactJS

Repository metrics

Stars
 (32,880 個のスター)
PR merge metrics
 (平均マージ 6d 5h) (30d で 318 merged PRs)

説明

The system-bot bot account can become disabled, which will, in turn, disable Mattermost features such as post reminders. The bot appears to tie itself to the original system admin account, and if that account is disabled and DisableBotsWhenOwnerIsDeactivated is set to true, the system bot will also be disabled We should consider making the system bot immune to being disabled through that process and continue to function.

The proposed solution is not to disable the system bot when the owner, i.e. the first admin, gets disabled. It’s worth check-in check if the system bot needs an OwnerID at all (https://github.com/mattermost/mattermost/blob/733f0a48c0d0b0715cf5fd8461b6577124c8b981/server/channels/app/bot.go#L186 ). The API should also block disabling the system bot. The buttons Create New Token - Edit - Disable should not be shown for the system bot.

If you have any questions, please reach out to @hanzei either in this ticket or on the Mattermost Community server.


If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-57388

コントリビューターガイド