mattermost/mattermost

RN: Improve Join Leave messages to only combine adjacent events of the same type and respect the order of events

Open

#23,196 opened on 2023年4月27日

GitHub で見る
 (4 comments) (0 reactions) (1 assignee)TypeScript (32,880 stars) (7,823 forks)batch import
Difficulty/2:MediumHelp WantedTech/React Native

説明

As in https://mattermost.atlassian.net/browse/MM-28338, we want join/leave messages on mobile to be grouped together as they are now, but we want to keep them in chronological order instead of grouping all join messages followed by all leave messages and so on.

Expected Behaviour:

  • System message should combine users with join, left, added, removed events on separate lines, in the order the events occur. We should keep the styling and copy of the messages as is, just change how they are ordered and grouped to respect the chronological order of events. For example:
3 joined
2 were removed
2 joined and left
3 joined
5 joined and left
4 were added by 
1 left

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-52545

コントリビューターガイド

技術スタック
reacttypescriptjavascript
領域
mobile
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
React Native basicsTypeScript fundamentals
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
60
調査方針
Investigate the current join/leave message grouping implementation in the React Native codebase, likely in components related to system messages (e.g., within `app/components/channel notice` or similar). Review the linked JIRA tickets (MM 28338, MM 52545) and any related PRs for context. The goal is to modify the grouping logic to combine only adjacent events of the same type while preserving chronological order, as described in the expected behavior. Start by locating the relevant code that handles join/leave event aggregation and update it to iterate through events in order, grouping consecutive same type events together.