mattermost-community/focalboard

Perf: Drag and drop cards in Kanban board view shows intermediate sort state

Open

#2,315 opened on 2022年2月11日

GitHub で見る
 (1 comment) (0 reactions) (0 assignees)TypeScript (26,187 stars) (2,542 forks)user submission
BugHelp WantedPerformanceSev/3Up for grabs

説明

Steps to reproduce the behavior

  1. Open a board (Kanban) view
  2. Drag a card onto another card in a column with multiple (5+) cards
  3. The card first appears at the beginning or end, then moves to the right position a split second later

Expected behavior

The card should move directly to the dropped position

Screenshots

https://user-images.githubusercontent.com/46905241/153519856-3a0fd910-a008-46d9-bfca-fd1ee70e68d1.mov

Edition and Platform

  • Edition: Mattermost plugin
  • Version: v0.14
  • Browser and OS: Chrome on Mac

Additional context

In the browser network tab, notice that PATCH Block is called twice. This is because on onDropToCard in kanban.tsx, the property change and sort order are two separate API calls. Propose refactoring to call UpdateBlocks in a single call.

コントリビューターガイド

技術スタック
typescriptreact
領域
frontend
Issue 種別
performance
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
fresh
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
ReactTypeScriptdrag and drop
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
70
調査方針
The issue is in the Kanban view component, specifically the `onDropToCard` function in `webapp/src/components/kanban/kanban.tsx` (line 172). Currently, two separate PATCH API calls are made for property change and sort order, causing a visual glitch. The fix is to refactor to call `UpdateBlocks` once with both changes. Investigate the `UpdateBlocks` function and ensure the batch call handles both fields correctly. Check if there are existing tests for this behavior to validate the change.