matrix-org/synapse

default in encryption_enabled_by_default_for_room_type is misleading

オープン

#9,794 opened on 2021/04/12

 (3 件のコメント) (0 件のリアクション) (0 人の担当者)Python (2,196 件のフォーク)batch import
T-Taskgood first issue

Repository metrics

Stars
 (11,713 個のスター)
PR merge metrics
 (PR metrics pending)

説明

Description

The option encryption_enabled_by_default_for_room_type as introduced in #7639 is misleading.

A default is something that has a value as long as it's not overwritten. In this case it would mean, that encryption is enabled for the specified room type as long as it is not disabled for a specific room/client/... The current implementation prevents creation of unencrypted DMs/rooms. This is clearly not a default, but forced encryption.

Expected Naming

force_encryption_enabled_for_room_type or similar.

Version information

v1.31.0 and current develop branch.

コントリビューターガイド