matrix-org/dendrite

Update Sentry reporting further

オープン

#3,306 opened on 2024/01/18

 (0 件のコメント) (0 件のリアクション) (0 人の担当者)Go (658 件のフォーク)auto 404
T-Taskgood first issue

Repository metrics

Stars
 (5,632 個のスター)
PR merge metrics
 (PR metrics pending)

説明

https://github.com/matrix-org/dendrite/pull/3305 made reporting errors a bit better, but there are still places in the code where we CaptureException in go routines, possibly still sending garbage to Sentry. For reference: https://docs.sentry.io/platforms/go/usage/concurrency/

It may also make sense to check if we even should report said errors to sentry, as e.g. we should always be able json.Unmarshal things we sent to JetStream ourselves.

コントリビューターガイド