matrix-org/dendrite

The transaction_id within events is not serialised in many endpoints

オープン

#3,000 opened on 2023/03/06

 (3 件のコメント) (0 件のリアクション) (0 人の担当者)Go (658 件のフォーク)auto 404
O-FrequentT-Defectgood first issuespec-compliance

Repository metrics

Stars
 (5,632 個のスター)
PR merge metrics
 (PR metrics pending)

説明

Similar to https://github.com/matrix-org/synapse/issues/15173 in Synapse

There are many endpoints that return events, and in those representations they should include the transaction_id in the unsigned part of the event.

I wrote a Complement test to highlight that Synapse had this issue by testing using the /rooms/{roomId}/event/{eventId} endpoint, and Dendrite also fails on this test. I haven't tested the other endpoints, nor covered them in the Complement test. https://github.com/matrix-org/complement/pull/621

コントリビューターガイド