matrix-org/dendrite

Move to zerolog

オープン

#1,468 opened on 2020/10/02

 (12 件のコメント) (4 件のリアクション) (0 人の担当者)Go (658 件のフォーク)auto 404
T-TaskX-Performancegood first issue

Repository metrics

Stars
 (5,632 個のスター)
PR merge metrics
 (PR metrics pending)

説明

We should move to use https://github.com/uber-go/zap or https://github.com/rs/zerolog instead of logrus because logrus does a loooooot of allocations, far more than the rest of Dendrite. I'd propose we use the sugared one since we're not looking for any specific improvement other than "why is logging consuming so much time/allocs". In terms of numbers:

  • logrus 29501 ns/op
  • zap 1250 ns/op (~24x speedup)

Allocations:

  • logrus 125 allocs/op
  • zap 11 allocs/op

コントリビューターガイド