matomo-org/matomo

Tracking code generator incorrectly sets domains for websites that use www in the hostname

Open

#19,844 opened on 2022年10月11日

GitHub で見る
 (0 comments) (0 reactions) (0 assignees)PHP (21,513 stars) (2,847 forks)batch import
Help wanted

説明

When setting the URL for a website, we specify that it isn't necessary to specify URLs with and without www as Matomo handles both automatically. This means that people can set their URL to either www.example.org or to example.org: image

However, when the option "Track Visitors across all subdomains" is selected in the tracking code generator it incorrectly sets the domains and cookie domains to *.www.example.org when the website URL contains www: image

This can cause issues with the cookies on the websites tracked with things such as cookie consent tools that are quite strict and can cause issues with other things such as server-side tracking that relies on fetching the Visitor ID value from cookies

コントリビューターガイド

技術スタック
なし
領域
backend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
under 1 hour
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
なし
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
75
調査方針
The bug is in the tracking code generator that constructs the ` paq.push(['setCookieDomain', ...])` and ` paq.push(['setDomains', ...])` lines. The code likely extracts the hostname without stripping the 'www.' prefix, resulting in incorrect wildcard domains. Look for files related to tracking code generation, such as in `plugins/Morpheus/templates/` or `core/Tracker/`. The fix should strip 'www.' from the hostname before generating the domain strings. Review the existing logic for handling URLs with 'www' and ensure the subdomain wildcard is applied to the bare domain.