mapbox/mapbox-gl-js

validate property names in getPaintProperty

オープン

#6,033 opened on 2018/01/22

 (2 件のコメント) (5 件のリアクション) (0 人の担当者)JavaScript (2,203 件のフォーク)batch import
api :memo:good first issue

Repository metrics

Stars
 (10,532 個のスター)
PR merge metrics
 (PR metrics pending)

説明

map.setPaintProperty(layer, key value) validates arguments but map.getPaintProperty does not. Providing a bad property key will trigger an internal error. It should trigger an error with a helpful errror message. Seen here: https://github.com/mapbox/mapbox-gl-js/issues/6030

mapbox-gl-js version: v0.43.0 and master

Steps to Trigger Behavior

  1. map.getPaintProperty("background", "fill-radius");

Expected Behavior

something like: "fill-radius" is not a paint property background layers"

Actual Behavior

Uncaught TypeError: Cannot read property 'value' of undefined

コントリビューターガイド