mapbox/mapbox-gl-js

Expose a "statechange" event on GeolocateControl

オープン

#5,136 opened on 2017/08/11

 (0 件のコメント) (2 件のリアクション) (0 人の担当者)JavaScript (2,203 件のフォーク)batch import
feature :green_apple:good first issue

Repository metrics

Stars
 (10,532 個のスター)
PR merge metrics
 (PR metrics pending)

説明

Motivation

Discussion started here: https://github.com/mapbox/mapbox-gl-js/pull/4479#issuecomment-321203924

The GeolocateControl doesn't expose events necessary to act on all of its states. trackuserlocationstart and trackuserlocationend aren't enough to detect some user actions. For instance, it's impossible to know if the user toggled off tracking.

To achieve this I currently have to use a MutationObserver on the .mapboxgl-ctrl-geolocate watching for classList changes.

Design

Fire a new statechange event on every _watchState change and pass along its value.

Implementation

Replace all this._watchState = ... with:

_setState(state) => {
  if (this._watchState !== state) {
    this._watchState = state
    this.fire('statechange', state)

    // ... conditions logic to fire trackuserlocationstart and trackuserlocationend
  
    // bonus?
    this._updateUI(state) // centralize the different classList updates spread in _onSucces, _onError, _onClick...
  }
}

コントリビューターガイド