mapbox/mapbox-gl-js

Stack not preserved in ajax.js

Open

#11,824 opened on 2022年4月25日

GitHub で見る
 (1 comment) (0 reactions) (0 assignees)JavaScript (10,532 stars) (2,203 forks)batch import
bug :lady_beetle:good first issue

説明

mapbox-gl-js version: 2.3.0, 2.8.1, etc

browser: Chrome etc

Steps to Trigger Behavior

  1. Somehow get an error with a puzzling message which hits https://github.com/mapbox/mapbox-gl-js/blob/main/src/util/ajax.js#L182 if (!aborted) callback(new Error(err.message));
  2. Notice that the new error discards the stack which makes figuring out the error difficult

Link to Demonstration

In my case the error showed up in tracking, and the repro steps are unclear. Hence, a stack trace would really help. The error message itself is Error: Cannot read properties of undefined (reading 'send') which is hard to debug, and it could be our bug, a mapbox bug, or anything else. So preserving the stack trace somehow or other would be useful to debug what is happening.

Obviously, stack preservation anywhere else errors are wrapped like this would be useful.

Expected Behavior

The error has a convenient stack trace from the original error

Actual Behavior

It does not

コントリビューターガイド

技術スタック
javascript
領域
frontend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
basic JavaScript error handlingfamiliarity with ajax.js
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
70
調査方針
The issue is in src/util/ajax.js around line 182 where a new Error is created without preserving the original stack. Look at how errors are wrapped in that function and consider using a library like 'verror' or manually copying the stack property. The PR #11825 or similar may have relevant discussion.