mapbox/mapbox-gl-js

map.fitBounds() with bearing does not fit the entire bounds

Open

#10,064 opened on 2020年11月1日

GitHub で見る
 (7 comments) (0 reactions) (0 assignees)JavaScript (10,532 stars) (2,203 forks)batch import
bug :lady_beetle:good first issue

説明

When map.fitBounds(...) is called with a bearing option passed in, it seems like the bearing is not taken into the account on calculating the appropriate zoom, resulting in part of the bounded area to not be in view.

mapbox-gl-js version: 1.12.0

browser: Chrome

Steps to Trigger Behavior

  1. Create a bounded area with a list of coordinates
  2. Call map.fitBounds(...) with bearing option set

Link to Demonstration

https://jsfiddle.net/_blahblahblah/k4vL6s5r/

Expected Behavior

When clicking on the 'Fit to Line at 29º Bearing' button in the demo link, all 6 stations should be in view.

Actual Behavior

Only 4 of the 6 stations are in view.

コントリビューターガイド

技術スタック
javascript
領域
frontend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Understanding of mapbox gl js APIBasic geometry for map boundsJavaScript proficiency
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
60
調査方針
Investigate the `fitBounds` implementation in the Mapbox GL JS source code (likely in `src/ui/map.js`). The calculation for zoom level does not account for bearing, causing bounds to be partially visible. Consider modifying the algorithm to compute the bounding box after applying the rotation, or use a different method to ensure all points are within the viewport. Review comments in the issue for any suggested fixes or related PRs.
map.fitBounds() with bearing does not fit the entire bounds · mapbox/mapbox-gl-js#10064 | Good First Issue