mapbox/mapbox-gl-js

FeatureLevelRemove- and SourceLevelRemove-Benchmarks in remove_paint_state.js are exactly the same

Open

#10,049 opened on 2020年10月23日

GitHub で見る
 (0 comments) (0 reactions) (0 assignees)JavaScript (10,532 stars) (2,203 forks)batch import
good first issue

説明

Unless I'm missing something, both benchmarks were already the same when they were added in #7761 by @peterqliu :

https://github.com/mapbox/mapbox-gl-js/blob/ff8e087b6e7cc9fe63eb4809a0895b38029a67e2/bench/benchmarks/remove_paint_state.js#L88-L100 https://github.com/mapbox/mapbox-gl-js/blob/ff8e087b6e7cc9fe63eb4809a0895b38029a67e2/bench/benchmarks/remove_paint_state.js#L102-L114

I haven't used these APIs yet, but I believe the SourceLevelRemove should have used something like this?

// No loop
this.map.removeFeatureState({source: 'land'});

Maybe also source-property level like this?

// No loop
this.map.removeFeatureState({source: 'land'}, 'bench');

コントリビューターガイド

技術スタック
javascript
領域
performancetesting
Issue 種別
test
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
under 1 hour
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
JavaScriptmapbox gl js API
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
70
調査方針
The issue identifies that the FeatureLevelRemove and SourceLevelRemove benchmarks in bench/benchmarks/remove paint state.js (lines 88-100 and 102-114) are identical, which is likely a copy paste error. The SourceLevelRemove benchmark should use `map.removeFeatureState({source: 'land'})` instead of looping over features. Review the mapbox gl js API documentation for `removeFeatureState` and consider whether a source property level removal (e.g., `map.removeFeatureState({source: 'land'}, 'bench')`) is more appropriate. The fix involves modifying the SourceLevelRemove benchmark function to replace the loop with the correct API call, ensuring it tests the intended functionality. After making the change, run the benchmarks to verify correctness.