mapbox/mapbox-gl-js
GitHub で見るFeatureLevelRemove- and SourceLevelRemove-Benchmarks in remove_paint_state.js are exactly the same
Open
#10,049 opened on 2020年10月23日
good first issue
Repository metrics
- Stars
- (10,532 stars)
- PR merge metrics
- (30d に merged PR はありません)
説明
Unless I'm missing something, both benchmarks were already the same when they were added in #7761 by @peterqliu :
https://github.com/mapbox/mapbox-gl-js/blob/ff8e087b6e7cc9fe63eb4809a0895b38029a67e2/bench/benchmarks/remove_paint_state.js#L88-L100 https://github.com/mapbox/mapbox-gl-js/blob/ff8e087b6e7cc9fe63eb4809a0895b38029a67e2/bench/benchmarks/remove_paint_state.js#L102-L114
I haven't used these APIs yet, but I believe the SourceLevelRemove should have used something like this?
// No loop
this.map.removeFeatureState({source: 'land'});
Maybe also source-property level like this?
// No loop
this.map.removeFeatureState({source: 'land'}, 'bench');