makeomatic/redux-connect

filter-ed promises not being executed in componentDidMount

Open

#30 opened on 2016年6月16日

GitHub で見る
 (6 comments) (0 reactions) (0 assignees)JavaScript (550 stars) (73 forks)batch import
bugenhancementhelp wanted

説明

BEGIN_GLOBAL_LOAD/END_GLOBAL_LOAD are dispatched on the client side even when filter stops the asyncConnect from blocking the render function. However, once the component is mounted, since the redux has saved the state loaded as true, it does not fetch the data. Due to this you have to manually redo the logic for re-fetching data in these instances. It would be nice to have some logic to ascertain that the promise is executed in componentDidMount.

コントリビューターガイド

技術スタック
javascriptreact
領域
frontend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
familiarity with redux connectReact component lifecycleJavaScript promises
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
50
調査方針
Examine the `asyncConnect` decorator implementation in the redux connect source code, focusing on how the `filter` prop affects promise execution and state management in `componentDidMount`. Review the issue comments for additional context and potential solutions. Consider creating a minimal reproduction and testing the expected behavior.
filter-ed promises not being executed in componentDidMount · makeomatic/redux-connect#30 | Good First Issue