enhancementhelp wanted
Repository metrics
- Stars
- (550 stars)
- PR merge metrics
- (30d に merged PR はありません)
説明
This line of code does not catch errors so instead they get lost in the event loop and the component never gets rendered correctly. Additionally, it's hard to catch and display the error in an isomorphic app.
Something like this would reproduce it:
@asyncConnect([{
deferred: true,
promise: () => {
throw new Error('whoops, this was not supposed to happen');
},
}])
class SomeComponent extends React.Component {
...
}
It should be fixable like this:
let promiseOrResult;
try {
promiseOrResult = item.promise(rest);
} catch (error) {
promiseOrResult = Promise.reject(error);
}