makeomatic/redux-connect

Handle thrown errors in promise callbacks

Open

#108 opened on 2017年2月23日

GitHub で見る
 (4 comments) (3 reactions) (0 assignees)JavaScript (550 stars) (73 forks)batch import
enhancementhelp wanted

説明

This line of code does not catch errors so instead they get lost in the event loop and the component never gets rendered correctly. Additionally, it's hard to catch and display the error in an isomorphic app.

Something like this would reproduce it:

@asyncConnect([{
  deferred: true,
  promise: () => {
    throw new Error('whoops, this was not supposed to happen');
  },
}])
class SomeComponent extends React.Component {
  ...
}

It should be fixable like this:

let promiseOrResult;
try {
  promiseOrResult = item.promise(rest);
} catch (error) {
  promiseOrResult = Promise.reject(error);
}

コントリビューターガイド

Handle thrown errors in promise callbacks · makeomatic/redux-connect#108 | Good First Issue