lyqht/Octokit-lite

[Unfork] Reset repository picker options after submission

オープン

#25 opened on 2022/10/04

 (3 件のコメント) (0 件のリアクション) (0 人の担当者)TypeScript (11 件のフォーク)auto 404
good first issue

Repository metrics

Stars
 (17 個のスター)
PR merge metrics
 (PR metrics pending)

説明

Description

Currently at Unfork, after deleting repositories, those repositories stay as options.

The RepositoryPicker component should reset options after user has submitted the repositories for deletion.

For TopicSpace, i think it is ok to leave the repositories selected there after users updated the topics as they might wanna add more topics to the same selected topics.

Relevant code

  • unfork/index.tsx -> Probably just need to reset the selectedItems state here.

But there may be unintended UX behaviors caused by downshift component after resetting the state, so please play around with the dropdown after making the changes to ensure that the component still work as intended.

コントリビューターガイド