llvm/llvm-project

SortIncludes should support "@import" lines in Objective-C

Open

#38,995 opened on 2018年11月13日

GitHub で見る
 (4 comments) (0 reactions) (1 assignee)C++ (10,782 forks)batch import
bugzillaclang-formatenhancementgood first issueobjective-c

Repository metrics

Stars
 (26,378 stars)
PR merge metrics
 (平均マージ 1d 2h) (30d で 1,000 merged PRs)

説明

Bugzilla Link 39647
Version 7.0
OS MacOS X
Reporter LLVM Bugzilla Contributor

Extended Description

At the moment, SortIncludes only handles #import and #include.

In Objective-C, modules can also be imported with @​import. These are currently ignored when sorting includes, but should also be supported.

Currently with SortIncludes:

#import "b.h"
#import "c.h"
#import <d/e.h>
@import Foundation;
#import "a.h"   <- sorting stops after first non-#include line

Should be:

#import "a.h"
#import "b.h"
#import "c.h"
#import <d/e.h>
@import Foundation;

コントリビューターガイド