llvm/llvm-project

[x86][armv8] Failure to use flag in unsigned underflow compare idiom

オープン

#161,036 opened on 2025/09/28

 (14 件のコメント) (0 件のリアクション) (1 人の担当者)C++ (10,782 件のフォーク)batch import
good first issuellvm:SelectionDAGmissed-optimization

Repository metrics

Stars
 (26,378 個のスター)
PR merge metrics
 (平均マージ 1d 2h) (30d で 1,000 merged PRs)

説明

It is a common idiom to check for unsigned underflow by doing a greater than compare between the difference and minuend:

#include <stdint.h>

uint64_t subIfNoUnderflow_clang(uint64_t a, uint64_t b) {
    uint64_t diff = a - b;
    return (diff > a)? a : diff;
}

Instead of using the carry flag, which is set by the subtraction, clang emits a compare instruction:

https://godbolt.org/z/ex5554M6P

subIfNoUnderflow_clang:
        mov     rax, rdi
        sub     rax, rsi
        cmp     rax, rdi
        cmovae  rax, rdi
        ret

Ideally it should produce:

subIfNoUnderflow_ideal:
        mov     rax, rdi
        sub     rax, rsi
        cmovb   rax, rdi
        ret

Related issues

#53432 #62696 #73847

コントリビューターガイド