llvm/llvm-project

AMDGPU should implement IR version of isFMAFasterThanFMulAndFAdd

Open

#108,751 opened on 2024年9月15日

GitHub で見る
 (12 comments) (0 reactions) (1 assignee)C++ (10,782 forks)batch import
backend:AMDGPUgood first issuemissed-optimization

Repository metrics

Stars
 (26,378 stars)
PR merge metrics
 (平均マージ 1d 2h) (30d で 1,000 merged PRs)

説明

TargetLowering has an IR variant of isFMAFasterThanFMulAndFAdd, and AMDGPU does not yet implement it.

As far as I can tell, this is only ever used in target code to implement isProfitableToHoist (e.g. AArch64 here https://github.com/llvm/llvm-project/blob/3ae71d154e5dfb5e5a5d27b3699b27ce2b55f44d/llvm/lib/Target/AArch64/AArch64ISelLowering.cpp#L16086)

So for this to be effective, isProfitableToHoist would also need to be implemented similarly.

コントリビューターガイド