linebender/druid

dropped message when closing window on windows

Open

#160 opened on 2019年9月17日

GitHub で見る
 (2 comments) (0 reactions) (0 assignees)Rust (9,091 stars) (567 forks)batch import
help wantedshell/win

説明

Not sure how seriously to take this, but it came up in #149, and we should know what's going on here.

I tested a bit on Windows as well (but see comment inline about key event matching which I had to bodge). The good news is that it seems pretty robust; I wasn't able to trigger any crashes. But there are signs it isn't quite right yet, I get this logged:

2019-09-14 13:52:18,273 ERROR [druid_shell::windows] dropped message 0x2, hwnd=0x220034, wparam=0x0, lparam=0x0

I did a modest (not incredibly deep) pass through the rest and it seems pretty good to me. I like that it's simpler than my PR (exposing less of the internal event dispatching) while also adding the Command abstraction. Basically I'm comfortable with this going in soon, seems like the major issue is stability around window lifetimes. Do we want to debug and fix that in this PR, or get the API in place and treat it as a separate bug?

コントリビューターガイド